#5106 HIGH Update.: Attaching a file to gmail msg caused the journal to crash

[Zarro Boogs per Child]

#5106: Attaching a file to gmail msg caused the journal to crash
-------------------------------+--------------------------------------------
  Reporter:  kimquirk          |       Owner:  tomeu   
      Type:  defect            |      Status:  new     
  Priority:  high              |   Milestone:  Update.1
 Component:  journal-activity  |     Version:          
Resolution:                    |    Keywords:  review- 
  Verified:  0                 |  
-------------------------------+--------------------------------------------
Changes (by marco):

  * keywords:  review+ => review-


Comment:

 I had an high level look to the patch. I suggest these improvements:

  * Let's just hide the resume button, it should be cleaner and less
 invasive.
  * Let's support the old ObjectChooser API. Ignore args to the constructor
 (with a deprecation warning) and return gtk dialog results from run.
  * Let's listen for owner name changes so that we quite the modal loop if
 the DS dies.

 I haven't reviewed the code in detail, so please have someone review it in
 detail before checking in (being quite large we want to be extra-careful
 here).

-- 
Ticket URL: <http://dev.laptop.org/ticket/5106#comment:8>
One Laptop Per Child <http://dev.laptop.org>
OLPC bug tracking system