#560 HIGH Opportu: Pylint sugar

[Zarro Boogs per Child]

#560: Pylint sugar
---------------------+------------------------------------------------------
  Reporter:  marco   |       Owner:  dcbw       
      Type:  defect  |      Status:  new        
  Priority:  high    |   Milestone:  Opportunity
 Component:  sugar   |     Version:             
Resolution:          |    Keywords:  review?    
  Verified:  0       |  
---------------------+------------------------------------------------------
Changes (by jennjacobsen):

  * keywords:  => review?

Comment:

 Some more pylint with my questions.

 pylint output:
 [root at localhost sugar]# sh pylint.sh
 ************* Module shell.shellservice
 E0602:119:ShellService.CurrentActivityChanged: Undefined variable 'iface'
 ************* Module sugar.network
 E0602:549:start_xmlrpc: Undefined variable 'loop'
 ************* Module sugar.graphics.palette
 E0602:494:PaletteActionBar.add_action: Undefined variable 'Button'
 E0602:497:PaletteActionBar.add_action: Undefined variable 'Icon'
 E0602:501:PaletteActionBar.add_action: Undefined variable 'self'



 ___________________________________

 "iface" undefined.

 sugar-jhbuild/source/sugar/shell/shellservice.py line 119 :

 def CurrentActivityChanged(self, activity_id):
         if os.path.exists('/etc/olpc-security'):
             self._get_rainbow_service().ChangeActivity(activity_id,
 dbus_interface=iface)


 I have no clue how to fix this one.
 __________________________________

 "loop" is undefined. Also, why is the call to this function commented out?

 sugar-jhbuild/source/sugar/sugar/network.py line 549

 def start_xmlrpc():
     server = GlibXMLRPCServer(("", 8888))
     inst = Test()
     server.register_instance(inst)
     gobject.idle_add(xmlrpc_test, loop)

 Maybe calling this function with the "loop". But, is this unused since
 it's commented out in main()? Should the code be removed?
 _________________________________


 "Button", "Icon", "self" are undefined.




 sugar-jhbuild/source/sugar/sugar/graphics.py lines 494, 497, 501

 class PaletteActionBar(gtk.HButtonBox):
     def add_action(label, icon_name=None):
         button = Button(label)

         if icon_name:
             icon = Icon(icon_name)
             button.set_image(icon)
             icon.show()

         self.pack_start(button)
         button.show()


 Don't know what to do about Button and Icon. Also the call to this
 function I think should be:
 class PaletteActionBar(self,gtk.HButtonBox):
 ____________________________________

-- 
Ticket URL: <https://dev.laptop.org/ticket/560#comment:7>
One Laptop Per Child <http://laptop.org/>