#3019 HIGH Trial-3: PATCH: Optimize get_activities by making it async

Zarro Boogs per Child bugtracker at laptop.org
Sat Aug 25 13:13:09 EDT 2007


#3019: PATCH: Optimize get_activities by making it async
---------------------+------------------------------------------------------
  Reporter:  J5      |       Owner:  tomeu               
      Type:  defect  |      Status:  new                 
  Priority:  high    |   Milestone:  Trial-3             
 Component:  sugar   |     Version:                      
Resolution:          |    Keywords:  optimization review?
  Verified:  0       |  
---------------------+------------------------------------------------------
Comment (by tomeu):

 Replying to [comment:9 tomeu]:
 > Replying to [comment:8 J5]:
 > >Also as you see using the async API isn't all that complex.
 >
 > Well, we have to maintain more than twice the amount of code in the
 wrappers. I'm just asking what concrete benefits we gain by doing this. If
 all calls in the wrappers had an async variant, we would have to maintain
 a lot more of code.

 Correction, the async version in your patch is 20 lines, where the sync is
 3. Calling code would have to define two more methods (callbacks) or use
 lambda funcs that could get hairy.

 Most of our wrapped methods are as simple and quick as get_activities, are
 you sure it's worth it?

 Even more when the issue that triggered all this work is the process
 startup time, not any concrete method call.

-- 
Ticket URL: <https://dev.laptop.org/ticket/3019#comment:10>
One Laptop Per Child <http://laptop.org/>



More information about the Bugs mailing list