#2030 NORM Trial-3: Activity wedge memory footprint representation

Zarro Boogs per Child bugtracker at laptop.org
Thu Aug 23 14:00:33 EDT 2007


#2030: Activity wedge memory footprint representation
---------------------+------------------------------------------------------
  Reporter:  Eben    |       Owner:  danw   
      Type:  defect  |      Status:  new    
  Priority:  normal  |   Milestone:  Trial-3
 Component:  sugar   |     Version:         
Resolution:          |    Keywords:  review?
  Verified:  0       |  
---------------------+------------------------------------------------------
Comment (by marco):

 {{{
      def _launching_changed_cb(self, activity, pspec):
 -        if activity.props.launching:
 -            self._start_pulsing()
 -        else:
 +        if not activity.props.launching:
              self._stop_pulsing()
 -        self._setup_palette()
 +            self._setup_palette()
 }}}

 You are removing self._start_pulsing here, intentional?

 {{{
 +    def _remove_shell_mappings(self, smaps, shell_mappings):
 +        for mapping in smaps.mappings:
 +            if shell_mappings.has_key(mapping.name):
 +                mapping.shared_clean = 0
 +                mapping.shared_dirty = 0
 }}}

 This is a bit confusing. Being a class method it seem like it would remove
 mappings from the object instance. It might be better to make it an helper
 function _substract_mapping (or something similar).

 About proc_smaps.py let's just keep a copy for now. I'm not sure what we
 want to do with the console in the medium term, so let's just punt on this
 issue for now.

 As discussed in irc it might be better to move the logic to the model,
 though I'd say to first get this in, we can refactor later.

-- 
Ticket URL: <http://dev.laptop.org/ticket/2030#comment:25>
One Laptop Per Child <http://laptop.org/>



More information about the Bugs mailing list