#2715 BLOC Trial-3: .xo install from journal

[Zarro Boogs per Child]

#2715: .xo install from journal
-------------------------------+--------------------------------------------
  Reporter:  dcbw              |       Owner:  danw   
      Type:  defect            |      Status:  new    
  Priority:  blocker           |   Milestone:  Trial-3
 Component:  journal-activity  |     Version:         
Resolution:                    |    Keywords:  review-
  Verified:  0                 |  
-------------------------------+--------------------------------------------
Changes (by tomeu):

  * keywords:  review? => review-

Comment:

 {{{
 +        jobject_activity = jobject.metadata['activity']
 +        if jobject_activity is not None:
 +            if get_activity_registry().get_activity(jobject_activity):
 +                # already installed
 +                return
 ...
 +        if jobject_activity is None:
 +            jobject.metadata['activity'] = bundle.get_service_name()
 +            datastore.write(jobject,
 +                            reply_handler=self._jobject_bundle_update_cb,
 +
 error_handler=self._jobject_bundle_update_error_cb)
 }}}

 Why don't we just check that the service name inside the bundle is not
 already in the activity registry?

 In this way, we would save one write to the datastore and wouldn't need to
 pollute the 'activity' property, that is used for a different purpose.

-- 
Ticket URL: <https://dev.laptop.org/ticket/2715#comment:8>
One Laptop Per Child <http://laptop.org/>