#2713 HIGH Trial-3: Add paging arrows to the activities frame
Zarro Boogs per Child
bugtracker at laptop.org
Tue Aug 14 10:06:12 EDT 2007
#2713: Add paging arrows to the activities frame
-------------------------------+--------------------------------------------
Reporter: tomeu | Owner: marco
Type: defect | Status: new
Priority: high | Milestone: Trial-3
Component: interface-design | Version:
Resolution: | Keywords: review-
Verified: 0 |
-------------------------------+--------------------------------------------
Comment (by marco):
I'm going to list several high level issue. Let's address these and then
we can review the patch in the detail.
* I don't think we need item-width, item-height, page-limit. We should
just scroll the viewport of one page, regardless from his content.
* set_content is not the kind of API we want. Given Eben explanations in
previous comments, I'd say to create a TrayButton object (which inherits
from ToolButton). The viewport should contain a Toolbar and we should have
add_item(item, index), remove_item(index) which will pack TrayButtons into
it. Later we might want to add TrayObject/TrayItem for non clickable
objects.
* We should use Animation/Animator for the animation. Should end up with
cleaner code and we can tweak animation ease as suggested by Eben.
* Packing ToolItems inside a HBox is probably bad, they are supposed to
be packed only inside toolbars afaik. We can just create two toolbars
(let/right) and add those to the box.
* Please add a test for this widget to tests/
* Forget about the empty space at the end problem you mentioned by mail
for now. I have a couple of ideas about it but it's going to be tricky, we
can address that in a second step. Just scroll to the end of the viewport
for the last page.
I think the code should end up being pretty simple. Please follow up if
you have any question or doubt.
--
Ticket URL: <http://dev.laptop.org/ticket/2713#comment:7>
One Laptop Per Child <http://laptop.org/>
More information about the Bugs
mailing list