#2773 HIGH Trial-3: Some sugar modules are running code on import causing hard to debug performance issues
Zarro Boogs per Child
bugtracker at laptop.org
Tue Aug 14 06:53:50 EDT 2007
#2773: Some sugar modules are running code on import causing hard to debug
performance issues
---------------------+------------------------------------------------------
Reporter: J5 | Owner: tomeu
Type: defect | Status: new
Priority: high | Milestone: Trial-3
Component: sugar | Version:
Resolution: | Keywords: review+
Verified: 0 |
---------------------+------------------------------------------------------
Changes (by tomeu):
* cc: smcv (added)
Comment:
Replying to [comment:3 marco]:
> Tomeu, I don't quite understand the dbus_helpers thing in general,
having it public feels bad to me. Why aren't we just dealing with this
inside datastore.py?
The idea is just not having to deal directly with dbus in datastore.py.
It's true that today datastore.py is not complex, so I won't oppose to
merging them.
> Also having a Store object and datastore.get_store() might make the code
nicer (avoid all the _get_data_store), though I don't have such a strong
feeling about that, not sure what's the best API wise.
Well, I'm more concerned about having the dbus connection open all time.
Perhaps we should do the Store object you mention and have the dbus
connection closed when Store is dereferenced.
Also, we should reopen the dbus connection if the datastore process dies,
so it will relaunched by the session bus.
This two concerns also apply to all our wrappers around dbus services
(bundle registry, clipboard, etc.) Simon, any advice you can give us here?
--
Ticket URL: <https://dev.laptop.org/ticket/2773#comment:7>
One Laptop Per Child <http://laptop.org/>
More information about the Bugs
mailing list