#1994 NORM Trial-3: Toolbar button states do not match visual design

[Zarro Boogs per Child]

#1994: Toolbar button states do not match visual design
------------------------+---------------------------------------------------
  Reporter:  Eben       |       Owner:  benzea 
      Type:  defect     |      Status:  new    
  Priority:  normal     |   Milestone:  Trial-3
 Component:  gtk-theme  |     Version:         
Resolution:             |    Keywords:  review?
  Verified:  0          |  
------------------------+---------------------------------------------------
Comment (by benzea):

 Replying to [comment:4 marco]:
 > Awesome! Some notes:
 >
 >  * Does this work in the Journal for you? I couldn't get it to work but
 it's late and I might be doing something stupid.
 Hm, is the journal using any palettes? I only see tooltips right now.

 >  * We are planning to replace the menu toplevel in SugarMenu so that we
 can pack the menu inside a VBox and be able to add widgets above and below
 it. I experimented with it and it seem like that can be done in a subclass
 (quite an hack but it seem to work well). When that happens would it be
 difficult to modify the patch to draw the border on the toplevel window
 rather than in the menu itself?
 That might make things a little bit nicer actually.

 >  * Should we do the queue_draw() directly inside Palette (through the
 Invoker object)? It would be nice to limit the code necessary to add
 palette support to a widget to the minimum.
 >  * For the same reason maybe in expose we could just call something like
 self._palette.draw_invoker_rect(event) and have the rest of the logic
 inside Palette.

 The thing here is that, AFAICT, we need to hook into the toolitem expose.
 So to change this the best we can do is hook into the expose there, and
 then draw the rectangle with the button as opposed to the toolitem.

 About queueing a redraw. Doing it on the toolitem kind of made more sense
 to me, but we can also queue the draw on the button instead.
 One thing though, the invoker currently does not have a reference to the
 palette. However the invoker needs to know the palette position and get
 the popup/popdown signals to queue redraws.


 >  * We have a 79 cols limit in the sugar style guidelines, it would be
 nice to fix that up.

 Oh, good point.

-- 
Ticket URL: <http://dev.laptop.org/ticket/1994#comment:5>
One Laptop Per Child <http://laptop.org/>