#2030 NORM Trial-3: Activity wedges should represent approximate memory footprint

[Zarro Boogs per Child]

#2030: Activity wedges should represent approximate memory footprint
---------------------+------------------------------------------------------
  Reporter:  Eben    |       Owner:  marco  
      Type:  defect  |      Status:  new    
  Priority:  normal  |   Milestone:  Trial-3
 Component:  sugar   |     Version:         
Resolution:          |    Keywords:  review+
  Verified:  0       |  
---------------------+------------------------------------------------------
Changes (by marco):

  * keywords:  review? => review+

Comment:

 {{{
 +            if not pid:
 +                continue
 }}}

 Let's log an error if this happen.

 {{{
 +            except:
 +                pass
 }}}

 Please handle the actual exceptions here (instead of trapping all of them)
 and log an error.

 +        except Exception, e:
 +            logging.warn('ActivitiesDonut: could not read /proc/meminfo')

 I think it would be better to handle specific exceptions here too.

 +        extra_space = max(0.0, 1.0 -
 ActivitiesDonut.MIN_ACTIVITY_WEDGE_SIZE * len(self._model))

 The style guide limit to 79 chars per line.

 I think it's good to commit with the above nitpicks fixed.


 To really close the bug I think need to figure out a refresh strategy.
 AFAICT we are currently only refreshing when a new activity is started.
 What about updating every time we switch to the home zoom level (before
 the switch ideally)? Or we could enable a refresh timeout only when we are
 in the home zoom level but... I'm not sure if that's necessary.

-- 
Ticket URL: <http://dev.laptop.org/ticket/2030#comment:8>
One Laptop Per Child <http://laptop.org/>