#2647 HIGH Trial-3: [PATCH] Security modifications to Sugar.

[Zarro Boogs per Child]

#2647: [PATCH] Security modifications to Sugar.
--------------------------+-------------------------------------------------
  Reporter:  coderanger   |       Owner:  dcbw   
      Type:  enhancement  |      Status:  new    
  Priority:  high         |   Milestone:  Trial-3
 Component:  sugar        |     Version:         
Resolution:               |    Keywords:  review?
  Verified:  0            |  
--------------------------+-------------------------------------------------
Comment (by marco):

 {{{
 +        self._rainbow = None
 +        if os.path.exists('/etc/olpc-security'):
 +            self._rainbow = False # Lazily bind this
 }}}

 I don't like the False trick. Please just add a _get_rainbow_service()
 method which lazily initialize self._rainbow, if lazy initialization is
 necessary. Or just get the service in CurrentActivityChanged if you are
 not planning to add more calls to the service in this class.

 {{{
 + factory.create_activity(self._service_name,
 }}}

 Should be CreateActivity. I've seen your comment about it on the mailing
 list but... how would this break Sugar?

 {{{
 + dbus-launch --exit-with-session --config-file=/etc/dbus-1/session-
 olpc.conf sugar-shell
 }}}

 Why do we need a custom conf here? What is going to install it?

-- 
Ticket URL: <http://dev.laptop.org/ticket/2647#comment:1>
One Laptop Per Child <http://laptop.org/>