#2622 NORM Untriag: autoreinstallation image fails with Page Fault

[Zarro Boogs per Child]

#2622: autoreinstallation image fails with Page Fault
----------------------------+-----------------------------------------------
  Reporter:  AlbertCahalan  |       Owner:  cscott   
      Type:  defect         |      Status:  new      
  Priority:  normal         |   Milestone:  Untriaged
 Component:  distro         |     Version:           
Resolution:                 |    Keywords:           
  Verified:  0              |  
----------------------------+-----------------------------------------------
Changes (by wmb at firmworks.com):

  * owner:  jg => cscott
  * status:  reopened => new

Comment:

 Ah, I see the problem.  The b-series firmware doesn't have a /mfg-data
 node, so the "find-package" in "serial-num$" and "uuid$" are failing
 (returning 0), but that is being ignored and "get-package-property" is
 being called anyway, with a nonexistent package handle.

 Here is a version of serial-num$ / uuid$ that fixes the problem - but it
 is probably best to do the firmware update and reboot before attempting to
 create the activation record, because old firmware that doesn't have the
 /mfg-data node doesn't the serial number even if it is present in the mfg
 data area in SPI FLASH.

 {{{
 : get-mfg-data$  ( tag$ -- true | value$ false )
    " /mfg-data" find-package  0=  if  ( tag$ )
       2drop true exit
    then                               ( tag$ phandle )
    get-package-property  if           ( )
       true exit
    then                               ( prop$ )
    get-encoded-string'  false         ( value$ false )
 ;
 : serial-num$  ( -- sn$ )
    " SN" get-mfg-data$  if  " SHF00000000"  then
 ;
 : uuid$  ( -- uuid$ )
    " U#" get-mfg-data$  if  " 00000000-0000-0000-0000-000000000000"  then
 ;
 }}}

-- 
Ticket URL: <http://dev.laptop.org/ticket/2622#comment:6>
One Laptop Per Child <http://laptop.org/>