[Trac #1303] olpc-hardware-manager in C

Zarro Boogs per Child bugtracker at laptop.org
Wed Apr 11 10:23:14 EDT 2007


#1303: olpc-hardware-manager in C
---------------------+------------------------------------------------------
 Reporter:  jochang  |        Owner:  blizzard
     Type:  defect   |       Status:  new     
 Priority:  normal   |    Milestone:  BTest-3 
Component:  distro   |   Resolution:          
 Keywords:           |  
---------------------+------------------------------------------------------
Comment (by dcbw):

 Nice!  Looks pretty good.  Two comments though:

 1) The timeout should be shorter for
 dbus_connection_read_write_dispatch(); say, 5 seconds perhaps.  If it's
 -1, the program will block in the select/poll for quite a long time and
 won't exit when sent a SIGTERM for that amount of time.  You can see this
 with dbus-monitor.  Ideally when sent a SIGTERM (on system shutdown, for
 instance) it should shut down pretty quickly.

 2) We need introspection support too; this means slightly more complicated
 code, since you have to deal with the "Introspect" method call.  But since
 the service isn't supposed to be that complex, you can definitely hardcode
 the Introspection XML, read it in at the start of the program, and just
 dump it back out when you get a request for Introspect.

 Thanks again; if you've got a little time, could you take a pass at doing
 these two things as well?  If you need any help or pointers, let us know.

-- 
Ticket URL: <http://dev.laptop.org/ticket/1303#comment:3>
One Laptop Per Child <http://laptop.org/>



More information about the Bugs mailing list