[Trac #638] olpc-bios-sig needs to be less strict
Zarro Boogs per Child
bugtracker at laptop.org
Mon Apr 9 23:58:17 EDT 2007
#638: olpc-bios-sig needs to be less strict
----------------------+-----------------------------------------------------
Reporter: dilinger | Owner: blizzard
Type: defect | Status: reopened
Priority: high | Milestone: BTest-3
Component: distro | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Comment (by wmb at firmworks.com):
That patch will probably work - but there is an alternative approach that
I think would be better still. Instead of burying the decision logic
inside olpc-bios-sig where it is hard to change and not easily visible, do
the testing in the shell script. olpc-bios-sig then becomes a single-
purpose too - read the signature.
I.e., in /etc/init.d/olpc-configure, instead of:
if /usr/sbin/olpc-bios-sig ; then
use
if [ `/usr/sbin/olpc-bios-sig | cut -c 7-8` == Q2 ]; then
I believe that this approach is more in keeping with our goals of
transparency and discoverability.
--
Ticket URL: <http://dev.laptop.org/ticket/638#comment:4>
One Laptop Per Child <http://laptop.org/>
More information about the Bugs
mailing list