Re: [Trac #278] Bad firmware causes WeirdShit® to happen.

[Zarro Boogs per Child]

#278: Bad firmware causes WeirdShit® to happen.
--------------------+-------------------------------------------------------
 Reporter:  dwmw2   |        Owner:  marcelo
     Type:  defect  |       Status:  new    
 Priority:  normal  |    Milestone:  BTest-1
Component:  distro  |   Resolution:         
 Keywords:          |  
--------------------+-------------------------------------------------------
Comment (by dcbw):

 Replying to [comment:7 dcbw]:
 > 2) There is some minimal firmware file verification in the driver on
 flash, but not, it appears, when uploading random firmware to the card.
 So the normal paths don't even care if the firmware validates or not, it
 just tries to dump it to the card.  The card is supposed to check the CRC
 of the uploaded blocks but maybe something dumb is happening here.  We
 _definitely_ should modify the driver to reject malformed firmware data.

 Clarification: When flashing the SPI flash, the driver does do minimal
 firmware validation.  But unless I'm wrong, the driver does _not_ do _any_
 firmware validation under normal operation, it just accepts what
 request_firmware() gives it and pushes it to the card.  The normal
 firmware files (ie usb8388.bin) do have a validatable file format that can
 be minimally checked for correctness.

-- 
Ticket URL: <http://dev.laptop.org/ticket/278#comment:8>
One Laptop Per Child <http://laptop.org/>